mikebridge commented on PR #45476: URL: https://github.com/apache/superset/pull/45476#issuecomment-6354356627
@eschutho thanks for the product review. The fixes for your findings are now on this PR. Could you take another look when you get a chance? - **Archive confirmation:** the dialog now just says the item will move to Recently Archived and can be recovered there. It no longer has a link, so there's no way to "visit" the archive before anything has been archived. - **Recovery links:** the direct link to Recently Archived now appears only in the success messages after a single or bulk archive, so it always points at something that exists. - **Recently Archived opening on the wrong type:** the menu now opens on the type you last archived in this browser, as long as you can still see that type. An explicit `?type=` in the URL still takes precedence. - **Smaller items:** toast wording, the page title, `?type=` handling, and the cursor and Edit state for unavailable actions. The PR description has been updated to match. The remaining polish items (toast hover, bulk counts, pagination, keyboard tooltip, RTL title) will follow in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
