mikebridge commented on PR #45476: URL: https://github.com/apache/superset/pull/45476#issuecomment-6428150752
Screenshots of the changes at the current head (`8507809e`), light theme, 1280×800. **Archive confirmation.** The title names the dashboard, and the hint says where it goes and how long it can be recovered: <img width="800" alt="Archive confirmation for a dashboard" src="https://github.com/user-attachments/assets/1eaac33b-5bf6-4022-9928-a420dc889878"; /> **Right-to-left names.** The name is isolated, so the question mark stays at the end of the title instead of moving into the Arabic text: <img width="800" alt="Archive confirmation for a right-to-left dashboard name" src="https://github.com/user-attachments/assets/fed7d6af-7bcc-4075-b716-24c00e0cb346"; /> **Recovery navigation.** The success toast links to Recently Archived, which now opens on the Dashboards collection (it used to always open on Charts): <img width="800" alt="Success toast with a link to Recently Archived" src="https://github.com/user-attachments/assets/484c4e0e-b823-4be9-b445-14cd08ba061b"; /> <img width="800" alt="Recently Archived opened on the Dashboards collection" src="https://github.com/user-attachments/assets/54bed386-4271-4c06-bd12-2c48ed56c82f"; /> **Users who can't edit.** Edit and Archive are disabled in the card menu, with a tooltip explaining why: <img width="800" alt="Card menu with Edit and Archive disabled and an explanatory tooltip" src="https://github.com/user-attachments/assets/589635cf-910c-4419-9e22-bdfd21bb12c2"; /> **Dataset impact.** The dialog states the counts in words and lists the affected objects. An unused dataset gets a plain sentence instead of a "0 charts, 0 dashboards" warning: <img width="800" alt="Dataset archive dialog for a dataset used by a chart on a dashboard" src="https://github.com/user-attachments/assets/8bbd74ac-2ac2-4dfa-afbf-4f53c56bc8a2"; /> <img width="800" alt="Dataset archive dialog for an unused dataset" src="https://github.com/user-attachments/assets/e86fb082-6304-40aa-a518-ae75afaa084c"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
