aminghadersohi commented on PR #45612: URL: https://github.com/apache/superset/pull/45612#issuecomment-6373317927
Correction to my earlier update at https://github.com/apache/superset/pull/45612#issuecomment-6372294373: its query-wide-range claim was too broad. Retaining a different column's saved range is wrong when the clicked chart used a saved or dashboard query-wide override instead. Fixed in df626c43a4e33b496ec911c53399d2faca7dd9a2: - Effective independent-date ranges are materialized before removing the global override, including `No filter`, saved, native and legacy dashboard shapes. Nested drills keep every outer bucket's clip, including cross-column and same-column nesting. Mixed Timeseries query B uses its own saved filter field for clipping. - Ungrained forced-categorical temporal Drill by labels use a readable timestamp instead of the raw epoch. The exact `==` comparator and drill scope are unchanged. Regression test: `nested same-column temporal drills cannot widen the outer bucket` in superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx. Additional regressions: `temporal drill retains the effective independent date range in query CSV and Explore: %j`, `nested same-column temporal drills cannot widen the outer bucket`, `Mixed Timeseries query B drills clip against its own saved temporal range`, and `ungrained forced-categorical temporal Drill by formats the timestamp label`. The previous mismatch-asserting helper test was replaced by effective-range and exact-row assertions for both mixed-query filter fields. The focused source-revert comparison gives 17 failures at 6c75c08436dd478fe8adab7c4eb24d8af7a36f80; those cases pass at this head. The absent-range compatibility case passes both. The preceding markerless line/area and both-query Mixed Timeseries changes remain in the passing suites. The four stale-response cases from https://github.com/apache/superset/pull/45612#discussion_r4349451049 also pass. Siblings checked: - superset-frontend/src/components/Chart/DrillBy/drillByTimeRange.ts — fixed in df626c43a4e33b496ec911c53399d2faca7dd9a2 - superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx — fixed in df626c43a4e33b496ec911c53399d2faca7dd9a2 - superset-frontend/src/components/Chart/DrillBy/useResultsTableView.tsx — not affected: CSV/XLSX and reload share the modal's normalized data, with format-only wrappers. - superset-frontend/src/explore/exploreUtils/formData.ts — not affected: Edit chart POST carries those same filters; the regression asserts its payload. - superset/commands/explore/get.py — not affected: the unchanged native/legacy merge preserves materialized filters, pinned by test_drilled_temporal_ranges_survive_explore_filter_merge in tests/unit_tests/utils/test_core.py. - superset-frontend/src/explore/actions/saveModalActions.ts — not affected: saved-from-drill charts serialize the merged form data unchanged. - superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/index.tsx — not affected: Explore pills read the merged comparator; the payload and merge contracts are covered, and its Jest suite passes. - superset-frontend/src/components/Chart/DrillDetail/utils.ts — not affected: separate detail payload builder and unchanged detail-event filters; the drill-by modal exposes only Drill by. Its suites pass. - superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx — fixed in df626c43a4e33b496ec911c53399d2faca7dd9a2 - superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx — not affected: ungrained mixed drills retain series-only scope; no ungrained x-axis epoch filter is emitted. - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/EchartsSunburst.tsx — not affected: uses the shared modal, with independent-date and clipped-bucket regression coverage. Validation: Docker Jest 43 suites, 806 passed / 1 skipped; explicit America/New_York container timezone 122 passed; Docker pytest 253 passed, including the entire touched Python suite; changed-branch-file pre-commit exited 0, including mypy and frontend types. Remaining: live UI/SQL acceptance was not run (localhost health unavailable). The existing time-range-resolution error fallback, cross-filter-chip ISO/column-name presentation, right-click discoverability, and Table/AG Grid Month-cell behavior are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
