aminghadersohi commented on PR #45612: URL: https://github.com/apache/superset/pull/45612#issuecomment-6372294373
@rebenitez1802 I reproduced the review body's independent-date-column regression. Fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80: a drill without a query-wide range leaves it unset; with independent temporal filters, saved/native/legacy range overrides are represented by the resolved clicked filter rather than overwriting other columns. Other date filters and outer drill buckets retain their values. Regression test: `Sunburst Drill by preserves an independent date filter without a saved time range` in `superset-frontend/src/components/Chart/DrillBy/DrillByTemporalFilters.test.tsx`. The three `temporal drill preserves an independent date filter in query and CSV with saved range %s` cases cover absent, No filter and bounded saved ranges, plus chart-data, CSV and Edit chart payloads. Two helper cases cover dashboard/legacy overrides and both mixed-query filter fields. The same commit also carries clicked grained buckets from markerless line/area charts and both Mixed Timeseries queries, and formats forced-categorical temporal bucket labels. Regression tests: `forced categorical temporal Drill by formats the bucket instead of an epoch label` and `Mixed Timeseries forced categorical temporal Drill by keeps a readable bucket`; the parameterized markerless and mixed-query regressions cover the other entry points. The focused comparison is 17 failures with the starting source, 17 passes with this commit. Three ungrained scope/label compatibility cases pass both before and after. An additional exact-match label guard prevents the readable-label change from leaking into ungrained forced-categorical drills. Siblings checked: - superset-frontend/src/components/Chart/DrillBy/drillByTimeRange.ts:191 — fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80 - superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx:419 — fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80 - superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx:683 — fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80 - superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/EchartsMixedTimeseries.tsx:222 — fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80 - superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:1149 — fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80 - superset-frontend/plugins/plugin-chart-echarts/src/utils/xAxisDrillByFilter.ts:170 — fixed in 6c75c08436dd478fe8adab7c4eb24d8af7a36f80 - superset-frontend/src/components/Chart/DrillBy/DrillBySubmenu.tsx:156 — not affected: forwards the bucket and formattedVal to the shared modal; scope-selection tests pass. - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/EchartsSunburst.tsx — not affected: creates its own segment filter and uses the shared modal, covered by the added independent-date regression. - superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx — not affected: its equality-based Month-cell path is outside this temporal-bucket change. - superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx — not affected: its equality-based Month-cell path is outside this temporal-bucket change. - superset-frontend/src/components/Chart/DrillBy/useResultsTableView.tsx:34 — not affected: reload and CSV/XLSX use the modal's shared normalized form data. Validation: Jest: 829 passed, 1 skipped (45 suites); America/New_York: 98 passed (4 suites); Docker backend temporal-query tests: 97 passed. Changed-file pre-commit (including type checking) passed. The four stale-response cases from https://github.com/apache/superset/pull/45612#discussion_r4349451049 still pass. Fresh live UI/SQL acceptance was not run: the local health endpoint was unavailable. Remaining: cross-filter-chip ISO display and differences in breadcrumb column names are unchanged; only the epoch bucket-label correction is included in this update. Right-click discoverability and Table/AG Grid Month-cell behavior are intentionally untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
