aminghadersohi commented on PR #45612: URL: https://github.com/apache/superset/pull/45612#issuecomment-6341059007
Acceptance of the dashboard Time grain change at ac63962198902587324923532e5d376d2610c6d7: ship. I ran 40 Drill by actions in a local docker-compose-light env on the examples dataset `cleaned_sales_data`, and every drilled total matched the clicked bar and a direct SQL count: - Dashboard Time grain Year over Month, Day, Week and line charts, horizontal Month and Day charts, and a forced-categorical temporal axis: 2003 = 1,000 and 2004 = 1,345. Quarter (2003 Q4 = 524), Month (Oct 2003 = 158, Nov 2003 = 296) and Day (2003-11-12 = 34) grains also match. - Year grain combined with a dashboard Time range of 2003-06-01 : 2004-01-01 returns 754. After an Oct 2003 cross-filter with the grain switched to Year in the filter bar, the drill returns 158, and a nested drill (Small, then product_line) returns 65. - Without filters, Day/Week/Month/Quarter/Year drills return 34/98/158/524/1,000. The ungrained axis keeps `==` and categorical Drill by keeps the chart range (1,384). - A Gamma viewer and an embedded guest (guest token) get the same totals, with no console errors. With `EchartsTimeseries.tsx` reverted to 4f27f242f34b32b4bd82c1d623b1a5b3f21514a6, the Year-grain drills returned 39 and 0 rows for bars of 1,000 and 1,345. The four new `EchartsTimeseries.test.tsx` cases fail at that file and pass at ac63962198902587324923532e5d376d2610c6d7. Screenshots in the description were re-captured at this head. This PR does not change Sunburst; that goes in https://github.com/apache/superset/pull/45571. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
