KristiDodaj commented on code in PR #45508:
URL: https://github.com/apache/superset/pull/45508#discussion_r4368383331
##########
superset/commands/report/update.py:
##########
@@ -496,6 +496,8 @@ def validate(self) -> None: # noqa: C901
self._properties.get("report_format", self._model.report_format),
exceptions,
)
+ # Always validate the effective Teams recipients, even for
metadata-only PUTs.
+ self.validate_teams_recipients(exceptions)
Review Comment:
Ah good call. Pausing and metadata edits now work when Teams is unavailable.
Activation and delivery changes still validate, with regression tests added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
