KristiDodaj commented on code in PR #45508:
URL: https://github.com/apache/superset/pull/45508#discussion_r4372175533
##########
superset/commands/report/update.py:
##########
@@ -131,7 +131,7 @@ def _normalize_recipients(recipients: Any) ->
list[tuple[str, str]]:
config = json.loads(config)
except json.JSONDecodeError:
pass
- if isinstance(config, dict):
+ if recipient_type == ReportRecipientType.EMAIL and isinstance(config,
dict):
Review Comment:
Figured those fields were irrelevant for Slack/Webhook, but missed that the
modal still sends them as empty values. Fixed so only Teams is excluded from
normalization, preserving the existing behaviour for the other methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
