sadpandajoe commented on code in PR #45508:
URL: https://github.com/apache/superset/pull/45508#discussion_r4372250567
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -1906,6 +1890,20 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
return false;
}
+ const hasTeamsRecipients = notificationSettings.some(
+ setting => setting.method === NotificationMethodOption.Teams,
+ );
+ const invalidTeamsRecipients =
+ hasTeamsRecipients &&
+ (!teamsSupported ||
+ !teamsIntegrationAvailable ||
Review Comment:
Once an existing Teams alert has been saved, turning off
`ALERT_REPORT_TEAMS`, removing the Teams config, or running without the
optional SDK makes `teamsIntegrationAvailable` false, so
`checkNotificationSettings` returns false and Save stays disabled for that
alert. The backend deliberately allows unchanged-delivery edits and
deactivation in that state (`_teams_delivery_changed` in `update.py`), but the
modal blocks them, so an operator can't pause the alert or fix its description
from the UI. Should the availability check only reject Teams recipients that
were added or changed, so pausing and metadata edits still save?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
