sadpandajoe commented on code in PR #43712:
URL: https://github.com/apache/superset/pull/43712#discussion_r4381255811


##########
UPDATING.md:
##########
@@ -2566,6 +2566,9 @@ Custom time ranges that use the "Now" or "Today" anchor 
(for the Start, End, or
 
 Charts and dashboards using these anchors will compute a different (correct) 
timestamp after upgrading; if a chart's filters or drill-downs were tuned to 
compensate for the old offset, review them after upgrading.
 
+- [43712](https://github.com/apache/superset/pull/43712): As the `ascend.io` 
platform shut down, its DB integration has been removed. Any existing users
+using `ascend://` DB protocol should switch to compatible `impala://` or 
preferentially remove the connection.

Review Comment:
   Understood that the platform is gone, but the note still tells anyone with a 
leftover `ascend://` connection that `impala://` is compatible. A chart saved 
at second granularity will hit `NotImplementedError` for the missing grain once 
switched. Could the sentence just say second-granularity charts need to be 
reworked after the switch, rather than calling it compatible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to