sadpandajoe commented on code in PR #43712: URL: https://github.com/apache/superset/pull/43712#discussion_r4450216866
########## UPDATING.md: ########## @@ -2637,6 +2637,9 @@ Custom time ranges that use the "Now" or "Today" anchor (for the Start, End, or Charts and dashboards using these anchors will compute a different (correct) timestamp after upgrading; if a chart's filters or drill-downs were tuned to compensate for the old offset, review them after upgrading. +- [43712](https://github.com/apache/superset/pull/43712): As the `ascend.io` platform shut down, its DB integration has been removed. Any existing users Review Comment: The note scopes the breakage to `ascend://` second-granularity charts, but deleting `ascend.py` also removes the `registry.register("ascend", "impala.sqlalchemy", "ImpalaDialect")` call, and nothing else registers that alias. Every persisted `ascend://` connection then fails to build a SQLAlchemy engine, so an operator with only daily charts or SQL Lab queries would read this, assume they are unaffected, and hit connection errors after upgrading. Could the entry say that all existing `ascend://` connections stop working and must be repointed or removed, rather than only the second-granularity charts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
