I3eka commented on PR #43134: URL: https://github.com/apache/superset/pull/43134#issuecomment-6433828179
Reviewed all 21 inline threads and the Copilot overview, and merged Apache master `1220ec01ef856de09fc9397f429f9fe1feb3e2ef` into this branch without rewriting its history. Replies are attached to every inline thread. The original telemetry fix is preserved: concrete tool errors reach telemetry only, and the regression drives both `WarehouseDeniedError` and unexpected `ZeroDivisionError` through the actual registry/runtime. | Remaining review finding | Change | | --- | --- | | Replays overwrite/restart runs; failed enqueue strands a row | `ae4a900f28`: stable accepted metadata, atomic execution claim, retryable pending submissions and terminal replay. | | Cancellation can target another conversation | `0b421058de`: owned-thread/run association checked before any flag write. | | Worker Stop uses a local cache | `3581cdc419`: shared event-bus Redis store, raw byte flag and TTL; real Redis-encoder regression. | | Concrete model is ignored | `62629364b3`: resolved pin reaches runtime/provider requests and telemetry. | | Helper directives are dropped | `9b436f6809`: bounded user-role instructions, tested through both provider paths. | | Retention is documented but absent | `969084bfe7`: pruning task and daily schedule; `bc53f21c16` also registers it in Helm. | | Helm omits AI tasks | `bc53f21c16`: bundled Celery imports and retention schedule; rendered-config regression. | | Global late acknowledgement and child failure | `437d15868f`: task-level early acknowledgement, parent failure/timeout callbacks and delivery ownership checks. Whole-parent/host loss is explicitly outside automatic recovery. | | Bad Redis host/credential still returns acceptance | `54e9ec627e`: PING before enqueue, socket/connect defaults with existing overrides, failed submission retryable under the same request ID. | | Fractional ID becomes another object's ID | `19093fe64b`: reject fractional/nonfinite values; no ID truncation. | Rechecked the existing unread-stream TTL, DONE-after-error/cancelled framing, unopened-conversation confirmation and suggestions configuration documentation. The exact history boundary is also fixed in `5771d1ac5d` so a queued turn cannot see questions submitted later. Validation: **829 backend tests, 106 frontend tests, 111 Helm tests**, plus all applicable pre-commit checks on **124 PR files**. The Redis-preflight, Helm-import and ID regressions failed before their fixes. No live Redis/provider/broker/warehouse, OS worker-kill, Kubernetes, browser, deployed migration or Docker test was run. PING is a point-in-time connection/authentication check; it cannot guarantee later availability or command permissions. @rusackas @sadpandajoe: the single-migration-head check passes locally. Current GitHub CI is separate from the earlier Databend job; the old result is not being treated as proof of this head. This stays **Draft / ON HOLD** behind #42805 and #42806. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
