mikebridge commented on code in PR #45649:
URL: https://github.com/apache/superset/pull/45649#discussion_r4395174707
##########
superset-frontend/src/features/semanticLayers/SemanticLayerModal.test.tsx:
##########
@@ -745,3 +772,379 @@ test('A pending clear prevents edits and a closed editor
ignores its late respon
await act(async () => finish({ json: {} }));
expect(props.addSuccessToast).not.toHaveBeenCalled();
});
+
+test('a successful edit after Cancel refreshes the parent without stale modal
UI', async () => {
Review Comment:
Added the missing timing case in 38454d6703. It rejects the save while the
dialog is open, waits for `getClientErrorObject` to start, cancels, then
resolves the error and checks that no danger toast appears. Removing the second
stale-request check makes this test fail on the toast; with the check in place,
the full modal suite passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
