mikebridge commented on code in PR #45649:
URL: https://github.com/apache/superset/pull/45649#discussion_r4402759437
##########
superset-frontend/src/features/semanticLayers/SemanticLayerModal.tsx:
##########
@@ -479,72 +532,122 @@ export default function SemanticLayerModal({
width={isTypeStep ? MODAL_STANDARD_WIDTH : MODAL_MEDIUM_WIDTH}
saveDisabled={
isTypeStep
- ? !selectedType
- : saving || clearing || !name.trim() || hasErrors
+ ? !selectedType || typeStatus !== 'success' || loading
+ : loading || saving || clearing || !name.trim() || hasErrors
}
saveText={isTypeStep ? undefined : isEditMode ? t('Save') : t('Create')}
saveLoading={saving}
- contentLoading={loading}
>
<ModalContent>
- {isTypeStep ? (
- <ModalFormField label={t('Type')}>
- <Select
- ariaLabel={t('Semantic layer type')}
- placeholder={t('Select a semantic layer type')}
- value={selectedType}
- onChange={value => setSelectedType(value as string)}
- options={types.map(type => ({
- value: type.id,
- label: type.name,
- }))}
- getPopupContainer={() => document.body}
- />
- </ModalFormField>
+ <SemanticLayerSetupHelp />
+ {loading ? (
+ <Loading />
) : (
<>
- {isEditMode && (
- <Button
- disabled={dirty || saving || clearing || refreshingSchema}
- loading={clearing}
- onClick={handleReloadMetadata}
- >
- {t('Reload metadata')}
- </Button>
+ {/* COPY-TBD: semantic setup guidance, pending product copy. */}
Review Comment:
Not final yet. I've asked product to review the copy. I'll update the text
and remove the `COPY-TBD` markers before this merges, and it won't land with
them in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
