rusackas commented on code in PR #45595: URL: https://github.com/apache/superset/pull/45595#discussion_r4395282146
########## superset-frontend/spec/helpers/swcJestTransformer.js: ########## @@ -0,0 +1,153 @@ +/** Review Comment: Heya @hainenber, fair point, and I won't pretend it's a fun file to read cold. It's contained to just this one spot though, has a dedicated test suite covering every shape @sadpandajoe found across our back-and-forth, and throws loudly instead of silently reverting to broken behavior if SWC's output ever changes shape. So I think the actual maintenance risk is lower than it looks on first read. Worth being honest about what it buys too: about 30 seconds on a cold-cache local run, nothing on CI since the sharded time came out the same either way. If that's not meaningful for people running locally, I'm perfectly happy just closing this instead of taking on the complexity. Curious what you both think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
