justinpark commented on PR #45495: URL: https://github.com/apache/superset/pull/45495#issuecomment-6453675912
Thanks @sadpandajoe, addressed in c74d330: - `DashboardPage`: the hydration marker is reset when `idOrSlug` changes and only set by the load that's still current (`isCurrentLoad` flag cleaned up with the effect), so a reused page instance or a slower earlier load can't leave a stale marker. Added a test with retained Redux state and a pending permalink asserting the builder stays absent until it resolves. - `useSyncActiveTabsToUrl`: skips the write when `window.location.pathname` differs from the router's, so it can't undo the post-save `navigateWithState` slug change. Added a test for it. - `constants.test.ts` now asserts `RESERVED_DASHBOARD_URL_PARAMS` contains `active_tabs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
