sadpandajoe commented on code in PR #45755:
URL: https://github.com/apache/superset/pull/45755#discussion_r4405455053
##########
.github/workflows/docker.yml:
##########
@@ -330,28 +377,168 @@ jobs:
assert_cache_push_for_master lean "3.11-slim-trixie-lean"
assert_cache_push_for_master py311 "3.11-slim-bookworm"
assert_cache_push_for_master py312 "3.12-slim-bookworm"
+ assert_platform_cache_refs superset linux/amd64 "3.11-slim-trixie"
+ assert_platform_cache_refs superset linux/arm64
"3.11-slim-trixie-arm64"
+ assert_platform_cache_refs dev linux/arm64
"3.11-slim-trixie-dev-arm64"
+ assert_platform_cache_refs py312 linux/arm64
"3.12-slim-bookworm-arm64"
+ assert_platform_master_tag superset linux/amd64 master
+ assert_platform_master_tag superset linux/arm64 master-arm
+ assert_platform_master_tag dev linux/amd64 master-dev
+ assert_platform_master_tag dev linux/arm64 master-dev-arm
+ assert_platform_master_tag py311 linux/arm64 master-py311-arm
Review Comment:
The manifest merge now sources `apache/superset:${GITHUB_SHA}[-<preset>]`
and its `-arm` twin, but none of these assertions check that tag or that its
`-arm` twin is produced; they only cover the mutable `master*` tags. If
supersetbot dropped or renamed the full-sha tag while keeping
`master`/`master-arm`, this job would still pass, and the first master publish
would push the amd64 images and then fail with `no per-commit tag found`. Could
the check also assert the full-sha tag and its `-arm` twin for each preset, so
the contract the merge step depends on is covered before the first real publish?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
