rusackas commented on code in PR #45755:
URL: https://github.com/apache/superset/pull/45755#discussion_r4412754653
##########
scripts/docker-build-extra-flags.sh:
##########
@@ -77,7 +84,22 @@ case "$BUILD_PRESET" in
;;
esac
+case "$PLATFORM" in
+ ""|linux/amd64) ;;
+ linux/arm64) CACHE_REF="${CACHE_REF}-arm64" ;;
+ *)
+ echo "Unsupported platform for the docker cache ref: $PLATFORM" >&2
+ exit 1
+ ;;
+esac
+
EXTRA_FLAGS="--cache-from=type=registry,ref=$CACHE_REF $EXTRA_FLAGS"
+# The release build compiles linux/arm64 and linux/amd64 in one job without a
+# platform, but the unsuffixed ref is now written only by the native amd64
+# publish; read the arm64 ref too so the arm64 half is not a cold build.
+if [ "$BUILD_MODE" = "release" ] && [ -z "$PLATFORM" ]; then
+ EXTRA_FLAGS="--cache-from=type=registry,ref=${CACHE_REF}-arm64 $EXTRA_FLAGS"
Review Comment:
Done in af8fa1b: `assert_release_tag` now checks that the `release` flags
read both the unsuffixed and `-arm64` cache refs, and that an explicit
`linux/amd64` release build does not add the `-arm64` one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
