rusackas commented on code in PR #45755:
URL: https://github.com/apache/superset/pull/45755#discussion_r4408761883
##########
scripts/docker-build-extra-flags.sh:
##########
@@ -77,6 +84,15 @@ case "$BUILD_PRESET" in
;;
esac
+case "$PLATFORM" in
+ ""|linux/amd64) ;;
+ linux/arm64) CACHE_REF="${CACHE_REF}-arm64" ;;
Review Comment:
Good catch. Release builds now also read the `-arm64` cache ref (only when
no platform is passed), and I added the `-arm64` entry to the three compose
`cache_from` lists, in d14c3e4.
##########
.github/workflows/docker.yml:
##########
@@ -330,28 +377,168 @@ jobs:
assert_cache_push_for_master lean "3.11-slim-trixie-lean"
assert_cache_push_for_master py311 "3.11-slim-bookworm"
assert_cache_push_for_master py312 "3.12-slim-bookworm"
+ assert_platform_cache_refs superset linux/amd64 "3.11-slim-trixie"
+ assert_platform_cache_refs superset linux/arm64
"3.11-slim-trixie-arm64"
+ assert_platform_cache_refs dev linux/arm64
"3.11-slim-trixie-dev-arm64"
+ assert_platform_cache_refs py312 linux/arm64
"3.12-slim-bookworm-arm64"
+ assert_platform_master_tag superset linux/amd64 master
+ assert_platform_master_tag superset linux/arm64 master-arm
+ assert_platform_master_tag dev linux/amd64 master-dev
+ assert_platform_master_tag dev linux/arm64 master-dev-arm
+ assert_platform_master_tag py311 linux/arm64 master-py311-arm
Review Comment:
Agreed. I added `assert_platform_sha_tags` to the command check: for every
preset it finds the full-sha tag in the amd64 dry-run and asserts the arm64 one
carries the same tag plus `-arm`, in d14c3e4. I could not run supersetbot
locally, so the first CI run of that job is the real check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
