gabotorresruiz commented on code in PR #45650: URL: https://github.com/apache/superset/pull/45650#discussion_r4414705656
########## pyproject.toml: ########## @@ -175,7 +175,7 @@ dremio = ["sqlalchemy-dremio>=3.0.5, <4"] # 1.1.10 already supports SQLAlchemy 2.0 (added `import_dbapi` in 1.1.7). drill = ["sqlalchemy-drill>=1.1.10, <3"] druid = ["pydruid>=0.6.5,<0.7"] -duckdb = ["duckdb>=1.5.5,<2", "duckdb-engine>=0.17.0"] +duckdb = ["duckdb>=1.5.5,<3", "duckdb-engine>=0.17.0"] Review Comment: Just a small note for the rebase: master moved the floor to 1.5.6 in #45705, so this line conflicts and should come out as: ```suggestion duckdb = ["duckdb>=1.5.6,<3", "duckdb-engine>=0.17.0"] ``` `requirements/development.txt` conflicts on the same pin; keeping `duckdb==2.0.0` there is the right resolution. ########## pyproject.toml: ########## @@ -240,8 +240,10 @@ mariadb = ["apache-superset[mysql]"] monetdb = ["sqlalchemy-monetdb>=2.1.0, <3", "pymonetdb>=1.9.1, <2"] mongodb = ["pymongosql>=0.7.4, <1"] mssql = ["pymssql>=2.4.2, <3"] -# motherduck is an alias for duckdb - MotherDuck works via the duckdb driver -motherduck = ["apache-superset[duckdb]"] +# motherduck is an alias for duckdb - MotherDuck works via the duckdb driver. +# MotherDuck does not support DuckDB 2.x clients yet (max 1.5.6, see +# https://motherduck.com/docs/duckdb-versions.json), so keep it on <2. +motherduck = ["apache-superset[duckdb]", "duckdb<2"] Review Comment: Not a blocker, more of a question. I confirmed the split is needed: on 2.0.0 the MotherDuck extension refuses to load with `Your DuckDB version (v2.0.0) is not yet supported by MotherDuck. The latest supported version is v1.5.6`, while on 1.5.6 it loads and only fails on the token. Since `[duckdb]` alone now lands on 2.0.0 and the MotherDuck page in the user docs installs `duckdb` unbounded, do you think it is worth pointing that page at the `motherduck` extra here, or is that better as a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
