Vitor-Avila opened a new pull request, #45911:
URL: https://github.com/apache/superset/pull/45911

   ### SUMMARY
   
   The official `databricks-sqlalchemy` dialect reports its driver as 
`databricks`, but Superset advertises `databricks-sql-python`. The 
available-databases API only includes dynamic-form parameters when the spec's 
default driver is installed, so this mismatch omits the form schema.
   
   Update the Python connector's default driver and driver mapping to 
`databricks`. This PR is limited to restoring the connection form; 
legacy-driver removal and connection migration are follow-up work.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: with the official dialect installed, the Databricks connection form 
can appear blank because its parameters are missing from the API response.
   
   After: the registered driver matches the spec, allowing the API to include 
the dynamic-form parameters.
   
   ### TESTING INSTRUCTIONS
   
   1. Install Superset's Databricks extra with `databricks-sqlalchemy` 2.x.
   2. Open **Settings → Database Connections → + Database**, then select 
Databricks.
   3. Verify that the connection fields render. The Databricks entry from 
`/api/v1/database/available/` should include `default_driver: "databricks"` and 
`parameters`.
   
   Local validation: pre-commit passed; 61 focused Databricks, multi-cloud, and 
engine-discovery unit tests passed. OAuth and installed-dialect SQL-rendering 
tests were excluded because unrelated failures were also reproduced on the 
unchanged base. Live UI validation was not performed because the local server 
was not running.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] fix(da... Vitor-Avila (via GitHub) via notifications
    • Re: [P... netlify[bot] (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... codecov[bot] (via GitHub) via notifications
    • Re: [P... mikebridge (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... sadpandajoe (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications

Reply via email to