Re: [PR] fix(databricks): restore the dynamic connection form [superset]

codeant-ai-for-open-source[bot] (via GitHub) via notifications Fri, 30 Oct 2026 18:17:23 -0700


codeant-ai-for-open-source[bot] commented on code in PR #45911:
URL: https://github.com/apache/superset/pull/45911#discussion_r4429768730



##########
superset/db_engine_specs/databricks.py:
##########
@@ -742,8 +742,8 @@ def validate_parameters(  # type: ignore
 class DatabricksPythonConnectorEngineSpec(DatabricksDynamicBaseEngineSpec):
     engine = "databricks"
     engine_name = "Databricks"
-    default_driver = "databricks-sql-python"
-    drivers = {"databricks-sql-python": "Databricks SQL Python"}
+    default_driver = "databricks"

Review Comment:
   **Suggestion:** If only a legacy Databricks driver is installed, the API 
omits this spec’s parameters but still selects this default; URI mode then uses 
the unavailable Python dialect and connections fail.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Api mismatch`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5bf95f9399e14d9b9f0c756dc312def0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5bf95f9399e14d9b9f0c756dc312def0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/db_engine_specs/databricks.py
   **Line:** 745:745
   **Comment:**
        *Api Mismatch: If only a legacy Databricks driver is installed, the API 
omits this spec’s parameters but still selects this default; URI mode then uses 
the unavailable Python dialect and connections fail.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45911&comment_hash=7c6045a43d2f379a75c89cc1204399558e6680e0f93fdb3f1670b11883f8491c&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45911&comment_hash=7c6045a43d2f379a75c89cc1204399558e6680e0f93fdb3f1670b11883f8491c&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(databricks): restore the dynamic connection form [superset]

Reply via email to