mikebridge commented on code in PR #45911:
URL: https://github.com/apache/superset/pull/45911#discussion_r4458136605
##########
superset/db_engine_specs/databricks.py:
##########
@@ -742,8 +742,8 @@ def validate_parameters( # type: ignore
class DatabricksPythonConnectorEngineSpec(DatabricksDynamicBaseEngineSpec):
engine = "databricks"
engine_name = "Databricks"
- default_driver = "databricks-sql-python"
- drivers = {"databricks-sql-python": "Databricks SQL Python"}
+ default_driver = "databricks"
Review Comment:
Good catch. Replacement #45989 keeps old `DBS_AVAILABLE_DENYLIST` entries
working: `databricks-sql-python` is a denylist alias for the native default.
The red-first test failed for the old name before the fix and passes for both
names afterward. The change is in
[396cd3fac9](https://github.com/mikebridge/superset/commit/396cd3fac9e9003cc234a91d75c15df66e1ed2dc).
Because the old configuration remains effective, I did not add an
`UPDATING.md` entry.
##########
superset/db_engine_specs/databricks.py:
##########
@@ -742,8 +742,8 @@ def validate_parameters( # type: ignore
class DatabricksPythonConnectorEngineSpec(DatabricksDynamicBaseEngineSpec):
engine = "databricks"
engine_name = "Databricks"
- default_driver = "databricks-sql-python"
- drivers = {"databricks-sql-python": "Databricks SQL Python"}
+ default_driver = "databricks"
Review Comment:
I checked this against the supported Databricks extra. Superset pins
`databricks-sqlalchemy` 2.x; [that package’s entry
point](https://github.com/databricks/databricks-sqlalchemy/blob/v2.0.10/pyproject.toml)
and dialect both report `databricks`. The `databricks-sql-python` name remains
for saved-URI/spec lookup compatibility, but the supported dialect does not
report it as an installed driver. Thus a legacy-only available-driver set
requires an unsupported/custom installation. Replacement #45989 preserves that
alias in
[396cd3fac9](https://github.com/mikebridge/superset/commit/396cd3fac9e9003cc234a91d75c15df66e1ed2dc);
no API fallback change is needed for the supported driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
