mikebridge commented on PR #45830: URL: https://github.com/apache/superset/pull/45830#issuecomment-6551942874
@fitzee Addressed the small follow-ups in f36e9aeebb731d156f9888bad6b47a8d0c47bd0f: - Header Preview waits until the current-version probe is known; loading and failed probes hide it. - Each Preview references its row's author/timestamp with `aria-describedby`, and the test id is `version-history-group-preview`. - Added current/non-current header assertions for groups with records and a loading → known → unavailable transition test. Both focused suites pass (53 tests), along with changed-file hooks. I left the nested `role="button"` structure alone here, since the kebab shares that existing pattern. That accessibility restructuring remains a separate follow-up; expanded-row preview, Restore, and Open as new are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
