mikebridge commented on code in PR #45830:
URL: https://github.com/apache/superset/pull/45830#discussion_r4444145285
##########
superset-frontend/src/features/versionHistory/SaveGroupItem.tsx:
##########
@@ -293,17 +296,8 @@ export default function SaveGroupItem({
}
};
- // The synthetic starting-version group (sc-120488) carries no change
- // rows, so the per-record ActionRow preview never renders for it —
- // without its own affordance the scope's "previewable like any other
- // version" would silently not hold. An explicit button (natively
- // keyboard-accessible) rather than a synthetic field-change row; the
- // current version has nothing to preview, mirroring ActionRow.
- const showCreationPreview =
- Boolean(group.creationKind) &&
- !hasRecords &&
- group.versionUuid != null &&
- !isCurrent;
+ // Every saved historical version is previewable without expanding its
changes.
+ const showPreview = currentKnown && group.versionUuid != null && !isCurrent;
Review Comment:
Good catch. Fixed in 877f2077e8: groups without change rows keep their only
Preview action when the current-version probe fails. Restore stays unavailable.
Added chart and dashboard regressions covering the failed probe, Preview click,
and absent Restore action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
