aminghadersohi commented on code in PR #45830:
URL: https://github.com/apache/superset/pull/45830#discussion_r4434193712
##########
superset-frontend/src/features/versionHistory/SaveGroupItem.tsx:
##########
@@ -293,17 +296,8 @@ export default function SaveGroupItem({
}
};
- // The synthetic starting-version group (sc-120488) carries no change
- // rows, so the per-record ActionRow preview never renders for it —
- // without its own affordance the scope's "previewable like any other
- // version" would silently not hold. An explicit button (natively
- // keyboard-accessible) rather than a synthetic field-change row; the
- // current version has nothing to preview, mirroring ActionRow.
- const showCreationPreview =
- Boolean(group.creationKind) &&
- !hasRecords &&
- group.versionUuid != null &&
- !isCurrent;
+ // Every saved historical version is previewable without expanding its
changes.
+ const showPreview = currentKnown && group.versionUuid != null && !isCurrent;
Review Comment:
If the newest-self probe fails but history loads, this also hides Preview on
the starting-version group. That group has no change rows, so it loses its only
preview action even though snapshot loading is independent of the probe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
