nextjohnp7 opened a new pull request, #45957: URL: https://github.com/apache/superset/pull/45957
### ๐ Summary This PR adds comprehensive test coverage and JSDoc type documentation for the `superset-embedded-sdk`. ### ๐งช Testing Area - **24 tests passing** across 3 test files. - `guestTokenRefresh.test.ts`: 16 test cases (epoch/ISO exp, malformed tokens, TTL boundaries). - `index.test.ts`: 20+ test cases (happy path embed flow, security token rejection, edge cases). - `withTimeout.test.ts`: 3 test cases. - Also fixed a boundary TTL test assertion (`toBeGreaterThan` -> `toBeGreaterThanOrEqual`). ### ๐ Type Definitions Area - Added JSDoc documentation to all major exported types (`GuestTokenFetchFn`, `UiConfigType`, `EmbedDashboardParams`, `Size`, `ThemeMode`, etc.). - Restored the missing `ResolvePermalinkUrlFn` type signature. ### โ Verification - `npx vitest --run --dir src` passes (24/24 tests). - `tsc --noEmit` passes with 0 errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
