nextjohnp7 commented on PR #45957: URL: https://github.com/apache/superset/pull/45957#issuecomment-6614905781
Hi @gabotorresruiz, thank you so much for the voluntary review! I really appreciate you taking the time to look into the SDK. I've applied all the suggestions you made: - Moved the JSDoc blocks to their correct places above the types. - Removed the duplicated tests in `guestTokenRefresh.test.ts`. - Removed the redundant `handles iframe navigation internally` test. Let me know if there's anything else that needs tweaking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
