nextjohnp7 commented on PR #45957: URL: https://github.com/apache/superset/pull/45957#issuecomment-6626109677
--- Hi @gabotorresruiz, thank you again for your thorough review! I've addressed all the points you raised: ## Changes Made 1. **Restored `superset-websocket/src/index.ts` from master** — The accidental SDK code replacement is reverted; the websocket server is intact again. 2. **Restored `superset-embedded-sdk/src/index.ts` from master** — The `embedDashboard` rewrite is reverted, so the iframe channel handoff (`postMessage` with `port2`), `uiConfig` bitmask, `guestTokenFetchTimeoutMs`, and `ThemeMode` behavior all match master. 3. **Moved JSDoc blocks above their correct export types** — `UiConfigType`, `EmbedDashboardParams`, `Size`, and `ThemeMode` now each have their doc block directly above the `export type` declaration, so consumers see the correct documentation on hover and in `dist/index.d.ts`. 4. **Restored existing tests from master** — No modifications to existing test logic or assertions in `guestTokenRefresh.test.ts` or `index.test.ts`. Only new test cases were added. ## Tests Added - `guestTokenRefresh.test.ts`: 5 new tests (very long TTL, TTL just above minimum, time travel, expires immediately, buffer period) - `index.test.ts`: 3 new tests (refresh retry delay, unmount during token refresh, iframe channel handoff) ## Verification - ✅ 35/35 tests passing (`vitest --run --dir src`) - ✅ `tsc --noEmit` passes with 0 errors - ✅ Pre-commit checks pass - ✅ `superset-websocket/src/index.ts` has zero diff against master The branch is ready for re-review. Let me know if anything else needs adjustment! --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
