mikebridge commented on PR #45912: URL: https://github.com/apache/superset/pull/45912#issuecomment-6643494274
Closing in favour of #46022, which carries the reduced change described above: the SDK leaves NULL placement and tie order to the provider, and the result cache only answers a limited query from a re-aggregated result when the whole result fits within the limit (otherwise it asks the provider). The NULL-placement conformance checker from this PR is dropped. Thanks again @aminghadersohi for the detailed reviews here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
