CodeWithPravinMaske commented on PR #45785: URL: https://github.com/apache/superset/pull/45785#issuecomment-6608849617
Thanks for the careful look. Agreed that Table, AG Grid and the server-side builder should behave the same. For the server-side `_table_queries`, I'll add the same file-export guard (skip the all-records and totals queries for csv/xlsx) with a unit test in this PR. For AG Grid, the export-filter tests from #44308 expect the totals query on downloads on purpose, so I'd rather not change that without its authors agreeing. If you think it should match, I'll mirror the guard there in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
