antalotec commented on PR #45973: URL: https://github.com/apache/superset/pull/45973#issuecomment-6601436788
`lint-frontend` failed in its `tsc` step, on `plugin-chart-ag-grid-table` importing `DEFAULT_MAX_ROW`, `DEFAULT_MAX_ROW_TABLE_SERVER` and `QueryModeLabel` from `@superset-ui/chart-controls`. This PR changes two comment lines in one `.tsx` plus a set of `.po` catalogs, so it cannot affect that resolution. Those symbols are exported — `index.ts` re-exports `./constants` — and neither file has changed in months. `plugin-chart-table` has an identical `tsconfig.json`, imports the same symbols, and compiled fine in the same run. `frontend-build`, `validate-frontend` and all the sharded frontend tests passed from the same image. In the log, `chart-controls: compiled in 0.383s` appears *after* the failure, which suggests `tsc --build` treated it as up to date while `--skip-lib` had not emitted its declarations. Could someone re-run the job? All 14 required contexts are green; `lint-frontend` is not among them, so this isn't blocking — but the red cross is misleading for anyone reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
