Raman-Katiyar commented on PR #46047: URL: https://github.com/apache/superset/pull/46047#issuecomment-6690604651
Update on the failing unit-test checks: I looked into the two failures in the unit-tests run, and both were caused by my change in `raise_for_access`: 1. `tests/unit_tests/dashboards/datasets_test.py::test_dashboard_datasets_dashboard_only_principal_gets_authorized_labels` — the new dashboard-membership grant for charts also ran when the chart has its own non-empty `viewers` list, so it could override an explicit chart-level restriction. 2. `tests/unit_tests/dashboards/semantic_view_access_test.py::test_guest_allowlist_denies_semantic_member_chart` — the same path called `is_viewer` for embedded guests, which raised `AttributeError` when no user is set on `g`, instead of failing closed. Fixed in e6cc6c6: - The dashboard-membership chart grant now applies only when the chart has no explicit `viewers` list of its own, and never for guest users — guests stay on the token-scoped path. - `is_viewer` now resolves the current user the same way `get_current_guest_user_if_guest` does in the same file, returning no subjects instead of raising when no user is set. Verification on the updated branch: both previously failing tests pass again (their two files: 207 passed), `tests/unit_tests/dashboards` 438 passed, `tests/unit_tests/security` + `tests/unit_tests/subjects` 1099 passed, the explore command unit tests 20 passed, and the new dashboard RBAC integration tests 3 passed, including both negative tests. Pre-commit passes on the changed file. Neither failing test was modified, and the per-datasource check is unchanged. The new push will need workflow approval again — could a maintainer please approve the CI run for the new head? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
