Raman-Katiyar commented on PR #46047: URL: https://github.com/apache/superset/pull/46047#issuecomment-6717690076
Rebased CI caught a real conflict with #44215 that the rebase introduced: the dashboard-membership grants in `raise_for_access` (the chart branch and the `slice_id` datasource helper) fired on any bare chart/datasource check, so under `VIEWER_PROMISCUOUS_MODE` they granted standalone chart access and let a dashboard editor copy charts they couldn't read — both new tests in `test_promiscuous_dashboard_access.py` failed. Pushed a fix (eda21b4) gating both grants on promiscuous mode not applying, so there the request-bound grants from #44215 govern; the legacy dashboard-RBAC behaviour with the flags off is unchanged. Also fixed the pre-commit failure (ruff-format on the `_current_subject_ids` comprehension). Verified locally: the full `tests/unit_tests/subjects/` suite (345 tests), the Explore command tests, and pre-commit all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
