john-bodley commented on a change in pull request #8935: [fix] Enforce the
query result data to be pandas.DataFrame
URL:
https://github.com/apache/incubator-superset/pull/8935#discussion_r364036236
##########
File path: superset/connectors/druid/models.py
##########
@@ -988,11 +988,9 @@ def values_for_column(self, column_name: str, limit: int
= 10000) -> List:
def get_query_str(self, query_obj, phase=1, client=None):
return self.run_query(client=client, phase=phase, **query_obj)
- def _add_filter_from_pre_query_data(
- self, df: Optional[pd.DataFrame], dimensions, dim_filter
- ):
+ def _add_filter_from_pre_query_data(self, df: pd.DataFrame, dimensions,
dim_filter):
Review comment:
The return type from `client.export_pandas()` is never `None` per
[here](https://github.com/druid-io/pydruid/blob/80cf6fe767817c8c30e908ea2e145bee09aa6d9b/pydruid/query.py#L202).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
