john-bodley commented on a change in pull request #8935: [fix] Enforce the
QueryResult.df to be a pandas.DataFrame object
URL:
https://github.com/apache/incubator-superset/pull/8935#discussion_r364353667
##########
File path: superset/viz.py
##########
@@ -1155,6 +1153,9 @@ def process_data(self, df, aggregate=False):
if fd.get("granularity") == "all":
raise Exception(_("Pick a time granularity for your time series"))
+ if df.empty:
Review comment:
Short circuiting as `pivot_table` will throw an exception if the
`pandas.DataFrame` is empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
