john-bodley commented on a change in pull request #8935: [fix] Enforce the
QueryResult.df to be a pandas.DataFrame object
URL:
https://github.com/apache/incubator-superset/pull/8935#discussion_r364352469
##########
File path: superset/connectors/druid/models.py
##########
@@ -1379,7 +1377,7 @@ def query(self, query_obj: Dict) -> QueryResult:
if df is None or df.size == 0:
return QueryResult(
- df=pd.DataFrame([]),
+ df=pd.DataFrame(),
Review comment:
This is equivalent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
