[GitHub] [incubator-superset] etr2460 opened a new pull request #9012: [SQL Lab] Add function names to autocomplete

[GitBox]

etr2460 opened a new pull request #9012: [SQL Lab] Add function names to 
autocomplete
URL: https://github.com/apache/incubator-superset/pull/9012
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Adds a new function to `db_engine_specs` for getting function names 
available in a database. Also implements this function for Presto and Hive.
   
   Then passes this result through the database API and adds it to the SQL Lab 
editor autocomplete
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Hive:
   <img width="326" alt="Screen Shot 2020-01-23 at 6 17 31 PM" 
src="https://user-images.githubusercontent.com/7409244/73040036-fccc5280-3e0c-11ea-8767-3cb7517d664a.png";>
   Presto:
   <img width="353" alt="Screen Shot 2020-01-23 at 6 17 45 PM" 
src="https://user-images.githubusercontent.com/7409244/73040037-fccc5280-3e0c-11ea-9907-183ac92219f6.png";>
   
   ### TEST PLAN
   Test with Hive and Presto and see function autocompletes. Test with mysql 
and ensure that autocompletes still work
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @dpgaspar @villebro @john-bodley @graceguo-supercat @betodealmeida 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org