etr2460 commented on a change in pull request #9012: [SQL Lab] Add function
names to autocomplete
URL:
https://github.com/apache/incubator-superset/pull/9012#discussion_r370449801
##########
File path: superset/models/core.py
##########
@@ -320,7 +324,7 @@ def get_quoter(self):
return self.get_dialect().identifier_preparer.quote
def get_df( # pylint: disable=too-many-locals
- self, sql: str, schema: str, mutator: Optional[Callable] = None
+ self, sql: str, schema: Optional[str] = None, mutator:
Optional[Callable] = None
Review comment:
`self.get_sla_engine` sets schema to None by default so I moved this up a
level to make my db query easier (since it's not schema dependent)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
