villebro edited a comment on issue #9012: [SQL Lab] Add function names to autocomplete URL: https://github.com/apache/incubator-superset/pull/9012#issuecomment-578265785 I seem to have just missed the train.. LGTM, but something worth considering: some dbs support defining UDFs per account/database/schema (e.g. Snowflake: `SHOW USER FUNCTIONS IN SCHEMA 'my_schema'`). While fetching global functions is most likely 99 % of use cases, adding the schema parameter to `get_function_names` could be used to add UDFs that are available in the chosen schema for the current user.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
