villebro commented on a change in pull request #9033: feat: Add schema to function retrieval and implement for Snowflake URL: https://github.com/apache/incubator-superset/pull/9033#discussion_r372779905
########## File path: superset/db_engine_specs/snowflake.py ########## @@ -14,12 +14,22 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +import re from datetime import datetime -from typing import Optional +from typing import List, Optional, TYPE_CHECKING from urllib import parse +import pandas as pd + +from superset import cache from superset.db_engine_specs.postgres import PostgresBaseEngineSpec +if TYPE_CHECKING: + # prevent circular imports + from superset.models.core import Database # pylint: disable=unused-import + +func_regex = re.compile(r"^((?<!SYSTEM$)(\w))+$") Review comment: Fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
