etr2460 commented on a change in pull request #9033: feat: Add schema to
function retrieval and implement for Snowflake
URL:
https://github.com/apache/incubator-superset/pull/9033#discussion_r373595873
##########
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##########
@@ -785,8 +786,17 @@ export function queryEditorSetSchemaOptions(queryEditor,
options) {
return { type: QUERY_EDITOR_SET_SCHEMA_OPTIONS, queryEditor, options };
}
-export function queryEditorSetTableOptions(queryEditor, options) {
- return { type: QUERY_EDITOR_SET_TABLE_OPTIONS, queryEditor, options };
+export function queryEditorSetTableOptions(
Review comment:
in general, i think it's best practice to make the function name match the
action type. let's correct that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
