suddjian commented on issue #9077: [SIP-35] Proposal for Improving Superset’s 
Python Code Organization
URL: 
https://github.com/apache/incubator-superset/issues/9077#issuecomment-586478075
 
 
   @metaperl 
   Reviewers should help ensure that code is organized, and I think that's the 
idea you were going for with that bullet point. This will be especially true 
once the Superset community arrives at a consistent plan for code organization. 
Reviewers can point to the plan and request that code fit the established 
patterns.
   
   But wording that idea as "who let these problems get into the codebase in 
the first place" reads like pointing fingers at the folks who wrote/reviewed 
the existing code, which is why I responded to it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to