john-bodley commented on a change in pull request #9161: fix: share column type
matching between model and result set
URL:
https://github.com/apache/incubator-superset/pull/9161#discussion_r381417639
##########
File path: superset/utils/core.py
##########
@@ -1227,11 +1227,58 @@ class TimeRangeEndpoint(str, Enum):
UNKNOWN = "unknown"
-class ReservedUrlParameters(Enum):
+class ReservedUrlParameters(str, Enum):
"""
Reserved URL parameters that are used internally by Superset. These will
not be
passed to chart queries, as they control the behavior of the UI.
"""
STANDALONE = "standalone"
EDIT_MODE = "edit"
+
+
+_DB_COLUMN_TYPES_NUMERIC: Tuple[str, ...] = (
Review comment:
Why the leading underscore? Also I wanted to check are these database
agnostic or should they reside in the DB engine specs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
