villebro commented on a change in pull request #9161: fix: share column type
matching between model and result set
URL:
https://github.com/apache/incubator-superset/pull/9161#discussion_r387635349
##########
File path: superset/connectors/sqla/models.py
##########
@@ -145,6 +145,27 @@ class TableColumn(Model, BaseColumn):
update_from_object_fields = [s for s in export_fields if s not in
("table_id",)]
export_parent = "table"
+ @property
+ def is_num(self) -> bool:
Review comment:
Good point; I thought these were part of the FAB model hence would be
difficult to rename, but they were not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
