villebro commented on a change in pull request #9161: fix: share column type
matching between model and result set
URL:
https://github.com/apache/incubator-superset/pull/9161#discussion_r387320410
##########
File path: superset/db_engine_specs/base.py
##########
@@ -134,6 +144,48 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
max_column_name_length = 0
try_remove_schema_from_table_name = True # pylint: disable=invalid-name
+ # default matching patterns for identifying column types
+ db_column_types: Dict[utils.DbColumnType, Tuple[Pattern, ...]] = {
+ utils.DbColumnType.NUMERIC: (
+ re.compile(r".*DOUBLE.*", re.IGNORECASE),
+ re.compile(r".*FLOAT.*", re.IGNORECASE),
+ re.compile(r".*INT.*", re.IGNORECASE),
+ re.compile(r".*NUMBER.*", re.IGNORECASE),
+ re.compile(r".*LONG.*", re.IGNORECASE),
+ re.compile(r".*REAL.*", re.IGNORECASE),
+ re.compile(r".*NUMERIC.*", re.IGNORECASE),
+ re.compile(r".*DECIMAL.*", re.IGNORECASE),
+ re.compile(r".*MONEY.*", re.IGNORECASE),
+ ),
+ utils.DbColumnType.STRING: (
+ re.compile(r".*CHAR.*", re.IGNORECASE),
+ re.compile(r".*STRING.*", re.IGNORECASE),
+ ),
+ utils.DbColumnType.TEMPORAL: (
+ re.compile(r".*DATE.*", re.IGNORECASE),
+ re.compile(r".*TIME.*", re.IGNORECASE),
+ ),
+ }
Review comment:
These regexes essentially do the same as the previous string matches
Before:
`"CHAR" in "NVARCHAR"`
After:
`re.compile(r".*CHAR.*", re.IGNORECASE).match("NVARCHAR")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
