villebro commented on a change in pull request #8867: Make schema name for the
CTA queries and limit configurable
URL:
https://github.com/apache/incubator-superset/pull/8867#discussion_r381416295
##########
File path: superset/views/core.py
##########
@@ -2342,9 +2361,11 @@ def sql_json_exec(
f"Query {query_id}: Template rendering failed: {error_msg}"
)
- # set LIMIT after template processing
- limits = [mydb.db_engine_spec.get_limit_from_sql(rendered_query),
limit]
- query.limit = min(lim for lim in limits if lim is not None)
+ # Limit is not appliced to the CTA queries if SQLLAB_CTAS_NO_LIMIT
flag is set to True.
Review comment:
typo; appliced -> applied
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
