villebro commented on a change in pull request #8867: Make schema name for the
CTA queries and limit configurable
URL:
https://github.com/apache/incubator-superset/pull/8867#discussion_r384755390
##########
File path: superset/views/core.py
##########
@@ -2334,9 +2346,14 @@ def sql_json_exec(
if not mydb:
return json_error_response(f"Database with id {database_id} is
missing.")
- # Set tmp_table_name for CTA
+ # Set tmp_schema_name for CTA
+ # TODO(bkyryliuk): consider parsing, splitting tmp_schema_name from
tmp_table_name if user enters
+ # <schema_name>.<table_name>
+ tmp_schema_name = schema # type: Optional[str]
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
