etr2460 commented on a change in pull request #9189: Upgrade typescript to 3.7.5
URL:
https://github.com/apache/incubator-superset/pull/9189#discussion_r383015209
##########
File path: superset-frontend/package-lock.json
##########
@@ -24712,9 +24712,9 @@
"integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c="
},
"typescript": {
- "version": "3.5.3",
- "resolved":
"https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz",
- "integrity":
"sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==",
+ "version": "3.8.2",
Review comment:
your PR title says this upgrades to 3.7.5, but it looks like it's actually
upgrading to 3.8.2. i assume this isn't a problem, but you might want to update
the title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]