ktmud commented on a change in pull request #9189: Upgrade typescript to 3.8.2
URL:
https://github.com/apache/incubator-superset/pull/9189#discussion_r383439910
##########
File path: superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
##########
@@ -19,7 +19,7 @@
import { safeStringify } from '../../../src/utils/safeStringify';
class Noise {
- public next: Noise;
+ public next!: Noise;
Review comment:
Thanks! I was new to typescript and was not really about the difference
between "?:" and "!:". Just followed one of the suggested fixes from tslint
(which is now deprecated I guess).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
