etr2460 commented on a change in pull request #9189: Upgrade typescript to 3.7.5
URL:
https://github.com/apache/incubator-superset/pull/9189#discussion_r383015431
##########
File path: superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
##########
@@ -19,7 +19,7 @@
import { safeStringify } from '../../../src/utils/safeStringify';
class Noise {
- public next: Noise;
+ public next!: Noise;
Review comment:
Looks like this should actually be a `?` since in the test, Noise types
don't always have a next set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
